Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry repeadetly re-downloads url dependencies during dependency solving #5902

Closed
3 tasks done
Jinior opened this issue Jun 23, 2022 · 3 comments · Fixed by python-poetry/poetry-core#405
Closed
3 tasks done
Labels
kind/bug Something isn't working as expected

Comments

@Jinior
Copy link

Jinior commented Jun 23, 2022

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

Issue

When solving dependencies poetry repeadetly re-downloads url dependencies. As can be seen in the attached pyproject.toml I have a url dependency which is downloaded many times during solving. This not only makes the resolving slower, but also makes it impossible in some cases because the server will give "429 too many tries" error after a while.

When running the poetry lock -vvv command the output shows that the package is constantly redownloaded.

I suspect the bug is due to cache misses in the deferred cache of the Provider class.

@Jinior Jinior added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Jun 23, 2022
@dimbleby
Copy link
Contributor

duplicate #2415

@Jinior
Copy link
Author

Jinior commented Jun 24, 2022

It is indeed a duplicate. When I initially read #2415 I thought it was about re-downloading a package during installing while it was already downloaded during locking; while my issue is about re-downloading packages during only locking. But I now see that #2415 covers both cases.

Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
3 participants