Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve consistency of Pool().remove_repository() #6213

Closed
2 tasks done
jre21 opened this issue Aug 22, 2022 · 1 comment · Fixed by #6214
Closed
2 tasks done

Improve consistency of Pool().remove_repository() #6213

jre21 opened this issue Aug 22, 2022 · 1 comment · Fixed by #6214
Labels
kind/feature Feature requests/implementations

Comments

@jre21
Copy link
Contributor

jre21 commented Aug 22, 2022 •
edited
Loading

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

Pool().remove_repository() is currently difficult to use correctly in poetry plugins because it leaves internal variables in an inconsistent state. This makes it difficult to correctly write plugins which can both add and remove repositories to/from poetry's pool. I've submitted my desired changes as #6214
@jre21 jre21 added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Aug 22, 2022
@jre21 jre21 mentioned this issue Aug 22, 2022
Merged
2 tasks
@mkniewallner mkniewallner removed the status/triage This issue needs to be triaged label Sep 18, 2022
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/feature Feature requests/implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure repository deletion is consistent
2 participants
@jre21 @mkniewallner