-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace poetry lock --check
with poetry check --lock
#6756
Labels
area/cli
Related to the command line
area/ux
Features and improvements related to the user experience
impact/deprecation
Introduces or relates to a deprecation
status/accepted
Feature request accepted for the roadmap
Comments
johnthagen
added
kind/feature
Feature requests/implementations
status/triage
This issue needs to be triaged
labels
Oct 9, 2022
neersighted
added
area/cli
Related to the command line
area/ux
Features and improvements related to the user experience
status/accepted
Feature request accepted for the roadmap
impact/deprecation
Introduces or relates to a deprecation
and removed
kind/feature
Feature requests/implementations
labels
Oct 10, 2022
2 tasks
2 tasks
2 tasks
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area/cli
Related to the command line
area/ux
Features and improvements related to the user experience
impact/deprecation
Introduces or relates to a deprecation
status/accepted
Feature request accepted for the roadmap
Feature Request
There is an important need for development teams to validate their Poetry configuration files and lockfile freshness in CI. This should ideally be done in a single, easy to understand command.
The following PR added
poetry lock --check
:The problem is that this is a somewhat strange UI, especially given that the separate
poetry check
command already exists (and existed). Sebastian noted this and asked for a revert (which must never have happened?):I propose, similar to Sebastian, that
poetry lock --check
be deprecated and its functionality moved topoetry check --lock
. This would be easier to teach and explain to new Poetry users and would keep all "file validation logic" underpoetry check
.poetry check --lock
would therefor be the superset of everything that is checked inpoetry check
andpoetry lock --check
so that a user can run a single command in CI and get all validation performed.@neersighted seemed to agree in:
poetry lock --check
validates pyproject.toml #6704 (comment)The text was updated successfully, but these errors were encountered: