Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid group names in poetry install --only are silently ignored #7303

Closed
4 tasks done
johnthagen opened this issue Jan 5, 2023 · 1 comment · Fixed by #7529
Closed
4 tasks done

Invalid group names in poetry install --only are silently ignored #7303

johnthagen opened this issue Jan 5, 2023 · 1 comment · Fixed by #7529
Labels
area/cli Related to the command line area/pyproject Metadata/pyproject.toml-related kind/feature Feature requests/implementations status/triage This issue needs to be triaged

Comments

@johnthagen
Copy link
Contributor

johnthagen commented Jan 5, 2023

  • Poetry version: 1.3.1
  • Python version: 3.10.8
  • OS version and name: macOS 12.6
  • pyproject.toml:
[tool.poetry]
name = "poetry-test"
version = "0.1.0"
description = ""
authors = []

[tool.poetry.dependencies]
python = "^3.10, <3.11"
typer = "*"

[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"
  • I am on the latest stable Poetry version, installed using a recommended method.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have consulted the FAQ and blog for any relevant entries or release notes.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

Running the following command for the simple project above does not generate an error:

$ poetry install --only batman

The real world case for this was in a real production application Dockerfile we misspelled a group name by a single character, and it was not obvious why some of the dependencies were not being installed and took several hours to debug.

I would recommend that poetry install --without, --with, --only should all validate that the group names passed them actually exist and error if not, printing an error that shows which group name was not valid.

@johnthagen johnthagen added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Jan 5, 2023
@neersighted neersighted added area/cli Related to the command line kind/feature Feature requests/implementations area/pyproject Metadata/pyproject.toml-related and removed kind/bug Something isn't working as expected labels Jan 5, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli Related to the command line area/pyproject Metadata/pyproject.toml-related kind/feature Feature requests/implementations status/triage This issue needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants