Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry install bad python version #77

Closed
jgirardet opened this issue Apr 30, 2018 · 6 comments
Closed

poetry install bad python version #77

jgirardet opened this issue Apr 30, 2018 · 6 comments
Labels
area/cli Related to the command line kind/feature Feature requests/implementations

Comments

@jgirardet
Copy link
Contributor

If poetry is installed with python 3.6, when you specifiy python2.7 in [tool.poetry.dependencies] it will create a virtualenv under python 3.6.
I know it's the intended behaviour (it's in the doc) but I think It's a real issue.

So poetry should check while creating virtualenv that the python version are not compatible (or not the expected one).
Good idea are every where and the pipenv way (specify --python 3.6 or - python 2.7) is maybe a good way to do it.

thanks for poetry

@ghost
Copy link

ghost commented May 3, 2018

I think poetry should at least give an error rather than creating an invalid virtualenv, otherwise what's the point of the python dependency option in the first place?

@jgirardet
Copy link
Contributor Author

maybe something like this :

Warning : THe current python version is not supported in pyproject.toml, do you want to continue ?(y/n).

and/ or

poetry run something
warning: you're running under a python version not supported in pyproject.toml

@sdispater
Copy link
Member

@jgirardet @rainyday Thanks both of you for your input. I agree that poetry should give some kind of feedback that there is an incompatibility. I will try to add it to the next feature release (`0.9.0')

And @rainyday the purpose of the python dependency is to declare for which Python versions your project is compatible with. This is particularly useful if you publish it.

@sdispater sdispater added enhancement area/cli Related to the command line labels May 4, 2018
@jgirardet
Copy link
Contributor Author

I can propose some help if you want

@cs01
Copy link

cs01 commented May 23, 2018

I am running into this too.

Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli Related to the command line kind/feature Feature requests/implementations
Projects
None yet
Development

No branches or pull requests

4 participants