Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--no-directory option seems not to be working #7945

Closed
4 tasks done
elben10 opened this issue May 18, 2023 · 13 comments
Closed
4 tasks done

--no-directory option seems not to be working #7945

elben10 opened this issue May 18, 2023 · 13 comments
Labels
kind/bug Something isn't working as expected status/triage This issue needs to be triaged

Comments

@elben10
Copy link

elben10 commented May 18, 2023

  • I am on the latest stable Poetry version, installed using a recommended method.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have consulted the FAQ and blog for any relevant entries or release notes.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

--no-directory seems to not be working (introduced in #6845). When i run the following command it raises the following error.
poetry install --no-root --no-directory
Path /src/dummy for dummy does not exist

As I understand it, the sole purpose of the option is to ignore directory dependencies. I have followed the example in FAQ. The dockerfile is also included in the gist

@elben10 elben10 added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels May 18, 2023
@elben10 elben10 changed the title --noo --no-directory option seems not to be working May 18, 2023
@Secrus
Copy link
Member

Secrus commented May 18, 2023

Pretty sure your path should be relative. As you can see in the error message, it is currently searching in the root directory /.

@elben10
Copy link
Author

elben10 commented May 18, 2023

It is correct that the current directory is the root, but the package is added relative to that (poetry add -e src/dummy). The reason that the current directory is the root is that it is run within a docker container. The default working directory of the python image is the root

@Secrus
Copy link
Member

Secrus commented May 18, 2023

Summoning @radoering @adriangb since they were the ones working on this.

@dimbleby
Copy link
Contributor

you did not provide your poetry.lock

@elben10
Copy link
Author

elben10 commented May 18, 2023

It is now included in the gist

@dimbleby
Copy link
Contributor

@adriangb

@adriangb
Copy link
Contributor

See #7923

@dimbleby
Copy link
Contributor

aha. Looks close, just wants the testcases to be fixed...?

@adriangb
Copy link
Contributor

Yes, and I'm a bit tied up this week unfortunately since we really want to make a V2 beta release for Pydantic. Only so much OSS one can handle 😅.

@dimbleby
Copy link
Contributor

maybe an unfortunate coincidence that poetry 1.5.0 is also imminent - it would be a shame to include this new function, broken on release. I'll leave a note in the 1.5.0 tracking issue so that someone can at least make a deliberate decision.

@radoering
Copy link
Member

@elben10 I just merged the fix into master. Can you try again, please?

@elben10
Copy link
Author

elben10 commented May 18, 2023

Works as expected. Thanks for the quick resolution

@elben10 elben10 closed this as completed May 18, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected status/triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

5 participants