You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched the issues of this repo and believe that this is not a duplicate.
I have searched the FAQ and general documentation and believe that my question is not already covered.
Feature Request
Title: Proportion of Time Spent on Cloning is Significant during poetry lock --no-update
Body:
While running Poetry and cProfile locally, I noticed that a significant amount of time is spent on the cloning process, as depicted in the image below.
I made some modifications to replace the clone operation with a shallow copy, copying only necessary attributes. (I adjusted it to pass the tests by defining "necessary attributes".)
As a result, I was able to significantly reduce the time spent on the cloning operation, as can be seen in the following image. In addition, the processing time also improved significantly:
From
Resolving dependencies... (58.9s)
to
Resolving dependencies... (34.5s)
Would you be interested in this improvement? If so, I would like to create a PR right away.
higumachan
changed the title
Proportion of Time Spent on Cloning is Significant during poetry lock --no-update
Proportion of Time Spent on Cloning is Significant during poetry lock --no-updateJul 28, 2023
I guess that whether a pull request is desirable or not will depend on what it looks like. Something that's obviously safe and a performance win is obviously wanted; something that trades performance for maintainability might not be
Feature Request
Title: Proportion of Time Spent on Cloning is Significant during
poetry lock --no-update
Body:
While running Poetry and cProfile locally, I noticed that a significant amount of time is spent on the cloning process, as depicted in the image below.
I made some modifications to replace the clone operation with a shallow copy, copying only necessary attributes. (I adjusted it to pass the tests by defining "necessary attributes".)
As a result, I was able to significantly reduce the time spent on the cloning operation, as can be seen in the following image. In addition, the processing time also improved significantly:
From
to
Would you be interested in this improvement? If so, I would like to create a PR right away.
environment
poetry: e8ca4b3
poetry-core: f09d84a -> 86a0ec388eb7581c3c3b3d0f78848aa85f434893
The text was updated successfully, but these errors were encountered: