Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PEP 639 #9670

Open
befeleme opened this issue Sep 4, 2024 · 7 comments
Open

Implement PEP 639 #9670

befeleme opened this issue Sep 4, 2024 · 7 comments
Labels
kind/feature Feature requests/implementations status/accepted Feature request accepted for the roadmap

Comments

@befeleme
Copy link

befeleme commented Sep 4, 2024

Issue Kind

Change in current behaviour

Description

See: https://peps.python.org/pep-0639

Additional context:

Impact

poetry now uses the license field from the custom [tool.poetry] table - this will enable unification under the specified main [project] table of pyproject.toml and map to a new core metadata field.
This also brings in a standardized way of specifying the license files in the package metadata, which will help the downstream consumers locate them unambiguously.

Workarounds

poetry now includes both the license expression (as SPDX) and the license files in the distribution. This will just make the declarations and metadata unified across many packaging tools.

@befeleme befeleme added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Sep 4, 2024
@Secrus
Copy link
Member

Secrus commented Oct 6, 2024

We will wait for packaging to support it and use their implementation.

@Secrus Secrus removed the status/triage This issue needs to be triaged label Oct 6, 2024
@Secrus Secrus added the status/accepted Feature request accepted for the roadmap label Nov 6, 2024
@carlwgeorge
Copy link

This looks to be implemented in packaging 24.2.

https://github.com/pypa/packaging/releases/tag/24.2

@dekim24
Copy link

dekim24 commented Dec 2, 2024

Hi - we started getting the following error when trying to update ruff to the latest version 0.8.1 which was released very recently. Is there some work that needs to be done for poetry to support packages using the new metadata 2.4 version? I checked that we already have the latest version of poetry, and also packaging==24.2 is already a transitive dependency.

Unable to determine package info for path: /var/folders/j3/<snip>/ruff-0.8.1-py3-none-linux_armv6l.whl

Unknown metadata version: 2.4

@martynvdijke
Copy link

We have the same problem

@andresdelfino
Copy link

urllib3 2.3.0 released today uses metadata version 2.4.

@edgarrmondragon
Copy link
Contributor

urllib3 2.3.0 released today uses metadata version 2.4.

@andresdelfino what problem is that causing for you? and have you seen astral-sh/ruff#14681 (comment)? It seems upgrading pkginfo fixes the metadata issues.

@andresdelfino
Copy link

urllib3 2.3.0 released today uses metadata version 2.4.

@andresdelfino what problem is that causing for you? and have you seen astral-sh/ruff#14681 (comment)? It seems upgrading pkginfo fixes the metadata issues.

Sorry, I had a problem because I was using a Poetry installation made before the new pkginfo came out. Running a new installation of Poetry solved the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Feature requests/implementations status/accepted Feature request accepted for the roadmap
Projects
None yet
Development

No branches or pull requests

7 participants