-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add output
option to build
and dist-dir
option to publish
command
#8828
Conversation
This also requires changes to the publishing setup, since using custom build output would make publishing the built artifacts with Poetry impossible. (This is also where my PR stalled) |
Thank for the comment @Secrus, I tried to take it into consideration! |
Could you rebase and resolve conflicts? |
3947445
to
dde5956
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @radoering could you also take a look?
Deploy preview for website ready! ✅ Preview Built with commit 9c9c143. |
option( | ||
"output", | ||
"o", | ||
"Set output directory for build artifacts. Default is `dist`.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally, we don't use backticks here (only in the docs), but I do not have strong feelings and did not found a reference for something else so 🤷
dde5956
to
aa3fe9a
Compare
output
option to build
command.output
option to build
and dist-dir
option to publish
command
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
output
option tobuild
command.dist-dir
option topublish
command.Resolves: #3586
Similar PR: #7208