Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trio-asyncio v0.8.0 crashes on import on py35 #33

Closed
njsmith opened this issue Aug 22, 2018 · 5 comments
Closed

trio-asyncio v0.8.0 crashes on import on py35 #33

njsmith opened this issue Aug 22, 2018 · 5 comments

Comments

@njsmith
Copy link
Member

njsmith commented Aug 22, 2018

Not sure whether py35 is intended to be supported or not, but noticed when testing trio-asyncio and pytest-trio together that current trio-asyncio seems to be crashing on import:

___________ ERROR collecting pytest_trio/_tests/test_trio_asyncio.py ___________
../../../../virtualenv/python3.5.2/lib/python3.5/site-packages/pytest_trio/_tests/test_trio_asyncio.py:2: in <module>
    import trio_asyncio
../../../../virtualenv/python3.5.2/lib/python3.5/site-packages/trio_asyncio/__init__.py:6: in <module>
    from .loop import *  # noqa
../../../../virtualenv/python3.5.2/lib/python3.5/site-packages/trio_asyncio/loop.py:171: in <module>
    _orig_run_get = _aio_event._get_running_loop
E   AttributeError: module 'asyncio.events' has no attribute '_get_running_loop'
@njsmith
Copy link
Member Author

njsmith commented Aug 22, 2018

Though... the same test seems to pass on py 3.5.3: https://ci.appveyor.com/project/touilleMan/pytest-trio/build/1.0.122/job/grrwby5hbttmq507
The travis failures we saw were on 3.5.0 and 3.5.2. So maybe 3.5.3 is OK?

@pquentin
Copy link
Member

@njsmith The code agrees with you: 3.5.3 is OK! According to GitHub, _get_running_loop() was added in CPython 3.5.3, and its public version get_running_loop() was added in 3.7.0.

@smurfix
Copy link
Collaborator

smurfix commented Aug 25, 2018

Documented: minimum supported version is 3.5.3

@smurfix smurfix closed this as completed Aug 25, 2018
@pquentin
Copy link
Member

Thanks! Do you think this could be specified in python_requires too? https://github.com/python-trio/trio-asyncio/blob/master/setup.py#L75

@smurfix
Copy link
Collaborator

smurfix commented Aug 25, 2018

Thanks, I missed that. Uploaded (waiting for CI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants