Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tox and/or pre-commit for static analysis checks #2699

Open
jakkdl opened this issue Jul 12, 2023 · 0 comments
Open

Use tox and/or pre-commit for static analysis checks #2699

jakkdl opened this issue Jul 12, 2023 · 0 comments

Comments

@jakkdl
Copy link
Member

jakkdl commented Jul 12, 2023

check.sh is getting kinda bloated with the addition of isort, codespell, and check_type_completeness - and trying to read the output from it to figure out what actually failed is kind of a pain. I've been using tox and pre-commit locally to avoid having to deal with the shell scripts, and been copying over configuration and commands, and maybe it's about time to share that and maybe make it official instead.

Setting up test environments in tox would also help people testing on different python versions and the like, although I've had some troubles with test_exports/ from inside tox envs (having to mess with PY_IGNORE_IMPORTMISMATCH, custom install_commands, and the like. It's definitely doable though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant