Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to test_exports that check allcaps constants re-exports #825

Open
njsmith opened this issue Dec 27, 2018 · 1 comment · May be fixed by #1245
Open

Add tests to test_exports that check allcaps constants re-exports #825

njsmith opened this issue Dec 27, 2018 · 1 comment · May be fixed by #1245

Comments

@njsmith
Copy link
Member

njsmith commented Dec 27, 2018

#791 added a test in test_subprocess.py to check that trio.subprocess is re-exporting all the constants from subprocess. We should move this to test_exports.py and generalize it to check trio.ssl and trio.socket, as well. (Or maybe we already have some tests in there for that? If so we should combine them instead of having multiple ad hoc duplicates of the same thing.)

@njsmith njsmith mentioned this issue Dec 28, 2018
3 tasks
@stevenjackson121
Copy link

@njsmith said in chat

we deprecated trio.subprocess and trio.ssl. But, we didn't deprecate trio.socket, so there might still be something that needs doing?

I'm assuming (if this issue is still relevant) we want to just add the tests for trio.socket in test_socket.py rather than moving it out to test_exports.py for the singular remaining case. If a different approach is preferred, please let me know!

@stevenjackson121 stevenjackson121 linked a pull request Oct 13, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants