Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that generated files are up to date #118

Closed
serhiy-storchaka opened this issue Jun 10, 2017 · 3 comments
Closed

Check that generated files are up to date #118

serhiy-storchaka opened this issue Jun 10, 2017 · 3 comments

Comments

@serhiy-storchaka
Copy link
Member

It is easy to forgot regenerating generated code after making changes (especially changes affecting Argument Clinic code). It would be nice if a bot checks this kind of errors. Just checkout the sources, run make clinic, make regen-all, and check that they are success and don't change any file.

@ncoghlan
Copy link
Contributor

Thanks @serhiy-storchaka, I was just coming here to file the same issue.

The specific prompt for this suggestion: I'd missed that the patch for https://bugs.python.org/issue19180#msg295524 updated some Argument Clinic inputs, so neither the original submission nor the backport included the regenerated files.

@zware
Copy link
Member

zware commented Jun 11, 2017

@zware zware closed this as completed Jun 11, 2017
@serhiy-storchaka
Copy link
Member Author

Thank you @zware!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants