Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checking code style for pull request #39

Open
methane opened this issue Mar 13, 2017 · 1 comment
Open

checking code style for pull request #39

methane opened this issue Mar 13, 2017 · 1 comment
Labels

Comments

@methane
Copy link
Member

methane commented Mar 13, 2017

In Github GUI, it's difficult to check 79 columns limitation.
How about adding pycodestyle --diff or something similar as non strict check?

@brettcannon
Copy link
Member

This has actually come up before and Guido didn't like the idea of automated style checking. I think the only way it would be acceptable is if a simple comment was left and it wasn't a review requirement or status check (i.e. more of a suggestion).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants