Skip to content

Commit 298131a

Browse files
author
Stefan Krah
committed
Issue #22090: Fix '%' formatting for infinities and NaNs.
1 parent d84fd73 commit 298131a

File tree

3 files changed

+14
-4
lines changed

3 files changed

+14
-4
lines changed

Lib/decimal.py

+2
Original file line numberDiff line numberDiff line change
@@ -3769,6 +3769,8 @@ def __format__(self, specifier, context=None, _localeconv=None):
37693769
if self._is_special:
37703770
sign = _format_sign(self._sign, spec)
37713771
body = str(self.copy_abs())
3772+
if spec['type'] == '%':
3773+
body += '%'
37723774
return _format_align(sign, body, spec)
37733775

37743776
# a type of None defaults to 'g' or 'G', depending on context

Lib/test/test_decimal.py

+5
Original file line numberDiff line numberDiff line change
@@ -1057,6 +1057,11 @@ def test_formatting(self):
10571057

10581058
# issue 6850
10591059
('a=-7.0', '0.12345', 'aaaa0.1'),
1060+
1061+
# issue 22090
1062+
('<^+15.20%', 'inf', '<<+Infinity%<<<'),
1063+
('\x07>,%', 'sNaN1234567', 'sNaN1234567%'),
1064+
('=10.10%', 'NaN123', ' NaN123%'),
10601065
]
10611066
for fmt, d, result in test_values:
10621067
self.assertEqual(format(Decimal(d), fmt), result)

Modules/_decimal/libmpdec/io.c

+7-4
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,7 @@ _mpd_to_string(char **result, const mpd_t *dec, int flags, mpd_ssize_t dplace)
446446

447447
if (mpd_isspecial(dec)) {
448448

449-
mem = sizeof "-Infinity";
449+
mem = sizeof "-Infinity%";
450450
if (mpd_isnan(dec) && dec->len > 0) {
451451
/* diagnostic code */
452452
mem += dec->digits;
@@ -609,10 +609,10 @@ _mpd_to_string(char **result, const mpd_t *dec, int flags, mpd_ssize_t dplace)
609609
*cp++ = (flags&MPD_FMT_UPPER) ? 'E' : 'e';
610610
cp = exp_to_string(cp, ldigits-dplace);
611611
}
612+
}
612613

613-
if (flags&MPD_FMT_PERCENT) {
614-
*cp++ = '%';
615-
}
614+
if (flags&MPD_FMT_PERCENT) {
615+
*cp++ = '%';
616616
}
617617

618618
assert(cp < decstring+mem);
@@ -1260,6 +1260,9 @@ mpd_qformat_spec(const mpd_t *dec, const mpd_spec_t *spec,
12601260
stackspec.align = '>';
12611261
spec = &stackspec;
12621262
}
1263+
if (type == '%') {
1264+
flags |= MPD_FMT_PERCENT;
1265+
}
12631266
}
12641267
else {
12651268
uint32_t workstatus = 0;

0 commit comments

Comments
 (0)