Remove unused code in _make_posargs

mjdominus · mjdominus · commit 4b8f4ac0a2df · 2024-05-22T02:14:12.000-04:00
`names_with_default` is never `NULL`, even if there are no names with defaults.
In that case it points to a structure with `size` zero.
diff --git a/Parser/action_helpers.c b/Parser/action_helpers.c
@@ -554,9 +554,6 @@ _make_posargs(Parser *p,
     else if (plain_names == NULL && names_with_default != NULL) {
         *posargs = _get_names(p, names_with_default);
     }
-    else if (plain_names != NULL && names_with_default == NULL) {
-        *posargs = plain_names;
-    }
     else {
         *posargs = _Py_asdl_arg_seq_new(0, p->arena);
     }

Original file line number	Diff line number	Diff line change
`@@ -554,9 +554,6 @@ _make_posargs(Parser *p,`
`554`	`554`	`else if (plain_names == NULL && names_with_default != NULL) {`
`555`	`555`	`*posargs = _get_names(p, names_with_default);`
`556`	`556`	`}`
`557`		`- else if (plain_names != NULL && names_with_default == NULL) {`
`558`		`- *posargs = plain_names;`
`559`		`- }`
`560`	`557`	`else {`
`561`	`558`	`*posargs = _Py_asdl_arg_seq_new(0, p->arena);`
`562`	`559`	`}`