Skip to content

Commit 882c7cf

Browse files
miss-islingtontiran
andauthoredAug 29, 2022
gh-94682: Build and test with OpenSSL 1.1.1q (gh-94683)
(cherry picked from commit 873554e) Co-authored-by: Christian Heimes <christian@python.org>
1 parent 626e455 commit 882c7cf

File tree

9 files changed

+27
-20
lines changed

9 files changed

+27
-20
lines changed
 

‎.azure-pipelines/ci.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ jobs:
5757
variables:
5858
testRunTitle: '$(build.sourceBranchName)-linux'
5959
testRunPlatform: linux
60-
openssl_version: 1.1.1n
60+
openssl_version: 1.1.1q
6161

6262
steps:
6363
- template: ./posix-steps.yml
@@ -83,7 +83,7 @@ jobs:
8383
variables:
8484
testRunTitle: '$(Build.SourceBranchName)-linux-coverage'
8585
testRunPlatform: linux-coverage
86-
openssl_version: 1.1.1n
86+
openssl_version: 1.1.1q
8787

8888
steps:
8989
- template: ./posix-steps.yml

‎.azure-pipelines/pr.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ jobs:
5757
variables:
5858
testRunTitle: '$(system.pullRequest.TargetBranch)-linux'
5959
testRunPlatform: linux
60-
openssl_version: 1.1.1n
60+
openssl_version: 1.1.1q
6161

6262
steps:
6363
- template: ./posix-steps.yml
@@ -83,7 +83,7 @@ jobs:
8383
variables:
8484
testRunTitle: '$(Build.SourceBranchName)-linux-coverage'
8585
testRunPlatform: linux-coverage
86-
openssl_version: 1.1.1n
86+
openssl_version: 1.1.1q
8787

8888
steps:
8989
- template: ./posix-steps.yml

‎.github/workflows/build.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ jobs:
203203
needs: check_source
204204
if: needs.check_source.outputs.run_tests == 'true'
205205
env:
206-
OPENSSL_VER: 1.1.1n
206+
OPENSSL_VER: 1.1.1q
207207
PYTHONSTRICTEXTENSIONBUILD: 1
208208
steps:
209209
- uses: actions/checkout@v3
@@ -262,7 +262,7 @@ jobs:
262262
strategy:
263263
fail-fast: false
264264
matrix:
265-
openssl_ver: [1.1.1n, 3.0.2]
265+
openssl_ver: [1.1.1q, 3.0.5]
266266
env:
267267
OPENSSL_VER: ${{ matrix.openssl_ver }}
268268
MULTISSL_DIR: ${{ github.workspace }}/multissl
@@ -309,7 +309,7 @@ jobs:
309309
needs: check_source
310310
if: needs.check_source.outputs.run_tests == 'true'
311311
env:
312-
OPENSSL_VER: 1.1.1n
312+
OPENSSL_VER: 1.1.1q
313313
PYTHONSTRICTEXTENSIONBUILD: 1
314314
ASAN_OPTIONS: detect_leaks=0:allocator_may_return_null=1:handle_segv=0
315315
steps:

‎Mac/BuildScript/build-installer.py

+12-6
Original file line numberDiff line numberDiff line change
@@ -246,9 +246,9 @@ def library_recipes():
246246

247247
result.extend([
248248
dict(
249-
name="OpenSSL 1.1.1n",
250-
url="https://www.openssl.org/source/openssl-1.1.1n.tar.gz",
251-
checksum='2aad5635f9bb338bc2c6b7d19cbc9676',
249+
name="OpenSSL 1.1.1q",
250+
url="https://www.openssl.org/source/openssl-1.1.1q.tar.gz",
251+
checksum='d7939ce614029cdff0b6c20f0e2e5703158a489a72b2507b8bd51bf8c8fd10ca',
252252
buildrecipe=build_universal_openssl,
253253
configure=None,
254254
install=None,
@@ -796,10 +796,16 @@ def verifyThirdPartyFile(url, checksum, fname):
796796
print("Downloading %s"%(name,))
797797
downloadURL(url, fname)
798798
print("Archive for %s stored as %s"%(name, fname))
799+
if len(checksum) == 32:
800+
algo = 'md5'
801+
elif len(checksum) == 64:
802+
algo = 'sha256'
803+
else:
804+
raise ValueError(checksum)
799805
if os.system(
800-
'MD5=$(openssl md5 %s) ; test "${MD5##*= }" = "%s"'
801-
% (shellQuote(fname), checksum) ):
802-
fatal('MD5 checksum mismatch for file %s' % fname)
806+
'CHECKSUM=$(openssl %s %s) ; test "${CHECKSUM##*= }" = "%s"'
807+
% (algo, shellQuote(fname), checksum) ):
808+
fatal('%s checksum mismatch for file %s' % (algo, fname))
803809

804810
def build_universal_openssl(basedir, archList):
805811
"""
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Build and test with OpenSSL 1.1.1q

‎PCbuild/get_externals.bat

+2-2
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ echo.Fetching external libraries...
5353
set libraries=
5454
set libraries=%libraries% bzip2-1.0.8
5555
if NOT "%IncludeLibffiSrc%"=="false" set libraries=%libraries% libffi-3.4.2
56-
if NOT "%IncludeSSLSrc%"=="false" set libraries=%libraries% openssl-1.1.1n
56+
if NOT "%IncludeSSLSrc%"=="false" set libraries=%libraries% openssl-1.1.1q
5757
set libraries=%libraries% sqlite-3.38.4.0
5858
if NOT "%IncludeTkinterSrc%"=="false" set libraries=%libraries% tcl-core-8.6.12.1
5959
if NOT "%IncludeTkinterSrc%"=="false" set libraries=%libraries% tk-8.6.12.1
@@ -77,7 +77,7 @@ echo.Fetching external binaries...
7777

7878
set binaries=
7979
if NOT "%IncludeLibffi%"=="false" set binaries=%binaries% libffi-3.4.2
80-
if NOT "%IncludeSSL%"=="false" set binaries=%binaries% openssl-bin-1.1.1n
80+
if NOT "%IncludeSSL%"=="false" set binaries=%binaries% openssl-bin-1.1.1q
8181
if NOT "%IncludeTkinter%"=="false" set binaries=%binaries% tcltk-8.6.12.1
8282
if NOT "%IncludeSSLSrc%"=="false" set binaries=%binaries% nasm-2.11.06
8383

‎PCbuild/python.props

+2-2
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@
6767
<libffiDir>$(ExternalsDir)libffi-3.4.2\</libffiDir>
6868
<libffiOutDir>$(ExternalsDir)libffi-3.4.2\$(ArchName)\</libffiOutDir>
6969
<libffiIncludeDir>$(libffiOutDir)include</libffiIncludeDir>
70-
<opensslDir>$(ExternalsDir)openssl-1.1.1n\</opensslDir>
71-
<opensslOutDir>$(ExternalsDir)openssl-bin-1.1.1n\$(ArchName)\</opensslOutDir>
70+
<opensslDir>$(ExternalsDir)openssl-1.1.1q\</opensslDir>
71+
<opensslOutDir>$(ExternalsDir)openssl-bin-1.1.1q\$(ArchName)\</opensslOutDir>
7272
<opensslIncludeDir>$(opensslOutDir)include</opensslIncludeDir>
7373
<nasmDir>$(ExternalsDir)\nasm-2.11.06\</nasmDir>
7474
<zlibDir>$(ExternalsDir)\zlib-1.2.12\</zlibDir>

‎PCbuild/readme.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ _lzma
168168
Homepage:
169169
https://tukaani.org/xz/
170170
_ssl
171-
Python wrapper for version 1.1.1k of the OpenSSL secure sockets
171+
Python wrapper for version 1.1.1q of the OpenSSL secure sockets
172172
library, which is downloaded from our binaries repository at
173173
https://github.com/python/cpython-bin-deps.
174174

‎Tools/ssl/multissltests.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@
4747
]
4848

4949
OPENSSL_RECENT_VERSIONS = [
50-
"1.1.1n",
51-
"3.0.2"
50+
"1.1.1q",
51+
"3.0.5"
5252
]
5353

5454
LIBRESSL_OLD_VERSIONS = [

0 commit comments

Comments
 (0)
Please sign in to comment.