Skip to content

Commit 993a130

Browse files
[3.9] bpo-45229: Make datetime tests discoverable (GH-28615). (GH-28645)
(cherry picked from commit d441437)
1 parent f7e99c9 commit 993a130

File tree

1 file changed

+47
-47
lines changed

1 file changed

+47
-47
lines changed

Lib/test/test_datetime.py

+47-47
Original file line numberDiff line numberDiff line change
@@ -1,57 +1,57 @@
11
import unittest
22
import sys
33

4-
from test.support import import_fresh_module, run_unittest
4+
from test.support import import_fresh_module
5+
56

67
TESTS = 'test.datetimetester'
78

8-
try:
9-
pure_tests = import_fresh_module(TESTS, fresh=['datetime', '_strptime'],
10-
blocked=['_datetime'])
11-
fast_tests = import_fresh_module(TESTS, fresh=['datetime',
12-
'_datetime', '_strptime'])
13-
finally:
14-
# XXX: import_fresh_module() is supposed to leave sys.module cache untouched,
15-
# XXX: but it does not, so we have to cleanup ourselves.
16-
for modname in ['datetime', '_datetime', '_strptime']:
17-
sys.modules.pop(modname, None)
18-
test_modules = [pure_tests, fast_tests]
19-
test_suffixes = ["_Pure", "_Fast"]
20-
# XXX(gb) First run all the _Pure tests, then all the _Fast tests. You might
21-
# not believe this, but in spite of all the sys.modules trickery running a _Pure
22-
# test last will leave a mix of pure and native datetime stuff lying around.
23-
all_test_classes = []
9+
def load_tests(loader, tests, pattern):
10+
try:
11+
pure_tests = import_fresh_module(TESTS, fresh=['datetime', '_strptime'],
12+
blocked=['_datetime'])
13+
fast_tests = import_fresh_module(TESTS, fresh=['datetime',
14+
'_datetime', '_strptime'])
15+
finally:
16+
# XXX: import_fresh_module() is supposed to leave sys.module cache untouched,
17+
# XXX: but it does not, so we have to cleanup ourselves.
18+
for modname in ['datetime', '_datetime', '_strptime']:
19+
sys.modules.pop(modname, None)
2420

25-
for module, suffix in zip(test_modules, test_suffixes):
26-
test_classes = []
27-
for name, cls in module.__dict__.items():
28-
if not isinstance(cls, type):
29-
continue
30-
if issubclass(cls, unittest.TestCase):
31-
test_classes.append(cls)
32-
elif issubclass(cls, unittest.TestSuite):
33-
suit = cls()
34-
test_classes.extend(type(test) for test in suit)
35-
test_classes = sorted(set(test_classes), key=lambda cls: cls.__qualname__)
36-
for cls in test_classes:
37-
cls.__name__ += suffix
38-
cls.__qualname__ += suffix
39-
@classmethod
40-
def setUpClass(cls_, module=module):
41-
cls_._save_sys_modules = sys.modules.copy()
42-
sys.modules[TESTS] = module
43-
sys.modules['datetime'] = module.datetime_module
44-
sys.modules['_strptime'] = module._strptime
45-
@classmethod
46-
def tearDownClass(cls_):
47-
sys.modules.clear()
48-
sys.modules.update(cls_._save_sys_modules)
49-
cls.setUpClass = setUpClass
50-
cls.tearDownClass = tearDownClass
51-
all_test_classes.extend(test_classes)
21+
test_modules = [pure_tests, fast_tests]
22+
test_suffixes = ["_Pure", "_Fast"]
23+
# XXX(gb) First run all the _Pure tests, then all the _Fast tests. You might
24+
# not believe this, but in spite of all the sys.modules trickery running a _Pure
25+
# test last will leave a mix of pure and native datetime stuff lying around.
26+
for module, suffix in zip(test_modules, test_suffixes):
27+
test_classes = []
28+
for name, cls in module.__dict__.items():
29+
if not isinstance(cls, type):
30+
continue
31+
if issubclass(cls, unittest.TestCase):
32+
test_classes.append(cls)
33+
elif issubclass(cls, unittest.TestSuite):
34+
suit = cls()
35+
test_classes.extend(type(test) for test in suit)
36+
test_classes = sorted(set(test_classes), key=lambda cls: cls.__qualname__)
37+
for cls in test_classes:
38+
cls.__name__ += suffix
39+
cls.__qualname__ += suffix
40+
@classmethod
41+
def setUpClass(cls_, module=module):
42+
cls_._save_sys_modules = sys.modules.copy()
43+
sys.modules[TESTS] = module
44+
sys.modules['datetime'] = module.datetime_module
45+
sys.modules['_strptime'] = module._strptime
46+
@classmethod
47+
def tearDownClass(cls_):
48+
sys.modules.clear()
49+
sys.modules.update(cls_._save_sys_modules)
50+
cls.setUpClass = setUpClass
51+
cls.tearDownClass = tearDownClass
52+
tests.addTests(loader.loadTestsFromTestCase(cls))
53+
return tests
5254

53-
def test_main():
54-
run_unittest(*all_test_classes)
5555

5656
if __name__ == "__main__":
57-
test_main()
57+
unittest.main()

0 commit comments

Comments
 (0)