gh-94841: Ensure arena_map_get() is inlined in PyObject_Free() (#94842)

neonene · web-flow · commit 9b3f7792093c · 2022-07-14T11:33:25.000-07:00
diff --git a/Misc/NEWS.d/next/Build/2022-07-14-02-45-44.gh-issue-94841.lLRTdf.rst b/Misc/NEWS.d/next/Build/2022-07-14-02-45-44.gh-issue-94841.lLRTdf.rst
@@ -0,0 +1 @@
+Fix the possible performance regression of :c:func:`PyObject_Free` compiled with MSVC version 1932.
diff --git a/Objects/obmalloc.c b/Objects/obmalloc.c
@@ -1446,7 +1446,7 @@ static arena_map_bot_t arena_map_root;
 
 /* Return a pointer to a bottom tree node, return NULL if it doesn't exist or
  * it cannot be created */
-static arena_map_bot_t *
+static Py_ALWAYS_INLINE arena_map_bot_t *
 arena_map_get(block *p, int create)
 {
 #ifdef USE_INTERIOR_NODES

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix the possible performance regression of :c:func:`PyObject_Free` compiled with MSVC version 1932.
Original file line number	Diff line number	Diff line change
`@@ -1446,7 +1446,7 @@ static arena_map_bot_t arena_map_root;`
`1446`	`1446`
`1447`	`1447`	`/* Return a pointer to a bottom tree node, return NULL if it doesn't exist or`
`1448`	`1448`	`* it cannot be created */`
`1449`		`-static arena_map_bot_t *`
	`1449`	`+static Py_ALWAYS_INLINE arena_map_bot_t *`
`1450`	`1450`	`arena_map_get(block *p, int create)`
`1451`	`1451`	`{`
`1452`	`1452`	`#ifdef USE_INTERIOR_NODES`