fix refleak of exit when __enter__ raises

python · Jan 31, 2023 · a925498 · a925498
1 parent 0a5f78d
commit a925498
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/Python/bytecodes.c b/Python/bytecodes.c
@@ -2331,7 +2331,10 @@ dummy_func(
             DECREF_INPUTS();
             res = _PyObject_CallNoArgs(enter);
             Py_DECREF(enter);
-            ERROR_IF(res == NULL, error);
+            if (res == NULL) {
+                Py_DECREF(exit);
+                ERROR_IF(true, error);
+            }
         }
 
         inst(WITH_EXCEPT_START, (exit_func, lasti, unused, val -- exit_func, lasti, unused, val, res)) {

diff --git a/Python/generated_cases.c.h b/Python/generated_cases.c.h