gh-112087: Remove duplicated critical_section (gh-114268)

corona10 · web-flow · commit d5442851a6fa · 2024-01-18T23:03:28.000Z
diff --git a/Objects/listobject.c b/Objects/listobject.c
@@ -816,13 +816,10 @@ static PyObject *
 list_insert_impl(PyListObject *self, Py_ssize_t index, PyObject *object)
 /*[clinic end generated code: output=7f35e32f60c8cb78 input=b1987ca998a4ae2d]*/
 {
-    PyObject *ret = Py_None;
-    Py_BEGIN_CRITICAL_SECTION(self);
-    if (ins1(self, index, object) < 0) {
-        ret = NULL;
+    if (ins1(self, index, object) == 0) {
+        Py_RETURN_NONE;
     }
-    Py_END_CRITICAL_SECTION();
-    return ret;
+    return NULL;
 }
 
 /*[clinic input]

Original file line number	Diff line number	Diff line change
`@@ -816,13 +816,10 @@ static PyObject *`
`816`	`816`	`list_insert_impl(PyListObject self, Py_ssize_t index, PyObject object)`
`817`	`817`	`/[clinic end generated code: output=7f35e32f60c8cb78 input=b1987ca998a4ae2d]/`
`818`	`818`	`{`
`819`		`- PyObject *ret = Py_None;`
`820`		`- Py_BEGIN_CRITICAL_SECTION(self);`
`821`		`- if (ins1(self, index, object) < 0) {`
`822`		`- ret = NULL;`
	`819`	`+ if (ins1(self, index, object) == 0) {`
	`820`	`+ Py_RETURN_NONE;`
`823`	`821`	`}`
`824`		`- Py_END_CRITICAL_SECTION();`
`825`		`- return ret;`
	`822`	`+ return NULL;`
`826`	`823`	`}`
`827`	`824`
`828`	`825`	`/*[clinic input]`