Skip to content

Commit d973307

Browse files
committed
Update comments
1 parent a3603f0 commit d973307

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

Lib/test/libregrtest/runtest.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ class EnvChanged(Failed):
8080
def __str__(self) -> str:
8181
return f"{self.name} failed (env changed)"
8282

83-
@staticmethod
8483
# Convert Passed to EnvChanged
84+
@staticmethod
8585
def from_passed(other):
8686
return EnvChanged(other.name, other.duration_sec, other.xml_data)
8787

Lib/test/libregrtest/runtest_mp.py

+3
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,9 @@ def _run_process(self, test_name: str, tmp_dir: str) -> tuple[int, str, str]:
271271
self.current_test_name = None
272272

273273
def _runtest(self, test_name: str) -> MultiprocessResult:
274+
# gh-93353: Check for leaked temporary files in the parent process,
275+
# since the deletion of temporary files can happen late during
276+
# Python finalization: too late for libregrtest.
274277
tmp_dir = os.getcwd() + '_tmpdir'
275278
tmp_dir = os.path.abspath(tmp_dir)
276279
try:

0 commit comments

Comments
 (0)