address review

Author: wimglenn

Lib/fractions.py

@@ -856,6 +856,8 @@ def __pow__(a, b, modulo=None):
         result will be rational.
 
         """
+        if modulo is not None:
+            return NotImplemented
         if isinstance(b, numbers.Rational):
             if b.denominator == 1:
                 power = b.numerator
@@ -877,8 +879,6 @@ def __pow__(a, b, modulo=None):
                 result = float(a) ** float(b)
         else:
             result = float(a) ** b
-        if modulo is not None:
-            result %= modulo
         return result
 
     def __rpow__(b, a):

Lib/test/test_fractions.py

@@ -1634,7 +1634,10 @@ def test_complex_handling(self):
                                  divmod, b, a)
 
     def test_three_argument_pow(self):
-        self.assertTypedEquals(pow(F(3), 4, 5), F(1))
+        message = "unsupported operand type(s) for ** or pow(): '%s', '%s', '%s'"
+        self.assertRaisesMessage(TypeError,
+                                 message % ("Fraction", "int", "int"),
+                                 pow, F(3), 4, 5)
 
 
 if __name__ == '__main__':

Misc/NEWS.d/next/Library/2024-05-26-22-22-51.gh-issue-119594.fnQNM8.rst

@@ -1 +1 @@
-fractions.Fraction.__pow__ accept optional modulo argument.
+Fraction.__pow__ accepts (but does not implement) optional modulo argument.