bpo-43637: Fix a possible memory leak in winreg.SetValueEx() (GH-25038)

ZackerySpytz · web-flow · commit dfeec347f21b · 2021-03-30T15:22:34.000+09:00
diff --git a/PC/winreg.c b/PC/winreg.c
@@ -1813,6 +1813,7 @@ winreg_SetValueEx_impl(PyObject *module, HKEY key,
     if (PySys_Audit("winreg.SetValue", "nunO",
                     (Py_ssize_t)key, value_name, (Py_ssize_t)type,
                     value) < 0) {
+        PyMem_Free(data);
         return NULL;
     }
     Py_BEGIN_ALLOW_THREADS

Original file line number	Diff line number	Diff line change
`@@ -1813,6 +1813,7 @@ winreg_SetValueEx_impl(PyObject *module, HKEY key,`
`1813`	`1813`	`if (PySys_Audit("winreg.SetValue", "nunO",`
`1814`	`1814`	`(Py_ssize_t)key, value_name, (Py_ssize_t)type,`
`1815`	`1815`	`value) < 0) {`
	`1816`	`+ PyMem_Free(data);`
`1816`	`1817`	`return NULL;`
`1817`	`1818`	`}`
`1818`	`1819`	`Py_BEGIN_ALLOW_THREADS`