Skip to content

Commit f89de67

Browse files
authored
Add "strict" to dotproduct(). Add docstring. Factor-out common code. (GH-100480)
1 parent 474220e commit f89de67

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Doc/library/itertools.rst

+3-2
Original file line numberDiff line numberDiff line change
@@ -834,7 +834,8 @@ which incur interpreter overhead.
834834
return chain.from_iterable(repeat(tuple(iterable), n))
835835

836836
def dotproduct(vec1, vec2):
837-
return sum(map(operator.mul, vec1, vec2))
837+
"Compute a sum of products."
838+
return sum(starmap(operator.mul, zip(vec1, vec2, strict=True)))
838839

839840
def convolve(signal, kernel):
840841
# See: https://betterexplained.com/articles/intuitive-convolution/
@@ -846,7 +847,7 @@ which incur interpreter overhead.
846847
window = collections.deque([0], maxlen=n) * n
847848
for x in chain(signal, repeat(0, n-1)):
848849
window.append(x)
849-
yield sum(map(operator.mul, kernel, window))
850+
yield dotproduct(kernel, window)
850851

851852
def polynomial_from_roots(roots):
852853
"""Compute a polynomial's coefficients from its roots.

0 commit comments

Comments
 (0)