Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide visualizations of executor graphs #126833

Open
markshannon opened this issue Nov 14, 2024 · 1 comment
Open

Provide visualizations of executor graphs #126833

markshannon opened this issue Nov 14, 2024 · 1 comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage type-feature A feature request or enhancement

Comments

@markshannon
Copy link
Member

markshannon commented Nov 14, 2024

Feature or enhancement

Proposal:

Visualizations can help us understand what is going on with executors. How they link to each other, where they drop to tier 1, etc, etc.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

@markshannon markshannon added type-feature A feature request or enhancement performance Performance or resource usage interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Nov 14, 2024
@markshannon
Copy link
Member Author

markshannon commented Nov 15, 2024

Here's a quick hacked up visualization of the executor graph after running the infamous pystones "benchmark".
It includes:

  • function names and line numbers of ENTER_EXECUTOR,
  • arrows attached to instructions, rather than exits
  • execution counts

executor_dump gv

@brandtbucher Is this good enough to start with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant