Skip to content

Derby #14: Convert 41 sites to Argument Clinic across 5 files #64382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
larryhastings opened this issue Jan 8, 2014 · 7 comments
Closed

Derby #14: Convert 41 sites to Argument Clinic across 5 files #64382

larryhastings opened this issue Jan 8, 2014 · 7 comments
Labels
3.9 only security fixes extension-modules C modules in the Modules dir topic-argument-clinic type-feature A feature request or enhancement

Comments

@larryhastings
Copy link
Contributor

BPO 20183
Nosy @larryhastings, @serhiy-storchaka, @ZackerySpytz
PRs
  • bpo-20183: Convert _locale to the Argument Clinic #14201
  • gh-64382: Convert the mmap module to the Argument Clinic #14207
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2014-01-08.00:18:09.883>
    labels = ['extension-modules', 'type-feature', 'expert-argument-clinic', '3.9']
    title = 'Derby #14: Convert 41 sites to Argument Clinic across 5 files'
    updated_at = <Date 2020-07-15.09:07:54.126>
    user = 'https://github.com/larryhastings'

    bugs.python.org fields:

    activity = <Date 2020-07-15.09:07:54.126>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Extension Modules', 'Argument Clinic']
    creation = <Date 2014-01-08.00:18:09.883>
    creator = 'larry'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 20183
    keywords = ['patch']
    message_count = 7.0
    messages = ['207640', '207651', '207653', '224764', '345984', '346003', '373673']
    nosy_count = 3.0
    nosy_names = ['larry', 'serhiy.storchaka', 'ZackerySpytz']
    pr_nums = ['14201', '14207']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue20183'
    versions = ['Python 3.9']

    @larryhastings
    Copy link
    Contributor Author

    This issue is part of the Great Argument Clinic Conversion Derby,
    where we're trying to convert as much of Python 3.4 to use
    Argument Clinic as we can before Release Candidate 1 on January 19.

    This issue asks you to change the following bundle of files:
    Modules/mmapmodule.c: 10 sites
    Modules/_localemodule.c: 10 sites
    Modules/zipimport.c: 9 sites
    Modules/ossaudiodev.c: 9 sites
    Modules/_testbuffer.c: 9 sites
    Modules/_struct.c: 3 sites

    Talk to me (larry) if you only want to attack part of a bundle.

    For instructions on how to convert a function to work with Argument
    Clinic, read the "howto":
    http://docs.python.org/dev/howto/clinic.html

    @larryhastings larryhastings added extension-modules C modules in the Modules dir type-feature A feature request or enhancement labels Jan 8, 2014
    @skrah
    Copy link
    Mannequin

    skrah mannequin commented Jan 8, 2014

    Could you take out _testbuffer.c? It has 100% coverage patches which
    would break and it is not a public module.

    @larryhastings
    Copy link
    Contributor Author

    Sure. Whoever takes ownership of this issue: please ignore _testbuffer.c.

    @larryhastings larryhastings changed the title Derby #14: Convert 50 sites to Argument Clinic across 6 files Derby #14: Convert 41 sites to Argument Clinic across 5 files Jan 8, 2014
    @larryhastings
    Copy link
    Contributor Author

    All the Derby patches should only go into trunk at this point.

    @ZackerySpytz
    Copy link
    Mannequin

    ZackerySpytz mannequin commented Jun 18, 2019

    PR 14201 converts Modules/_localemodule.c.

    @ZackerySpytz ZackerySpytz mannequin added the 3.9 only security fixes label Jun 18, 2019
    @ZackerySpytz
    Copy link
    Mannequin

    ZackerySpytz mannequin commented Jun 18, 2019

    PR 14207 converts Modules/mmapmodule.c.

    @serhiy-storchaka
    Copy link
    Member

    New changeset bbceef6 by Zackery Spytz in branch 'master':
    bpo-20183: Convert _locale to the Argument Clinic (GH-14201)
    bbceef6

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes extension-modules C modules in the Modules dir topic-argument-clinic type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants