Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the codecov GH Action #83958

Closed
brettcannon opened this issue Feb 27, 2020 · 4 comments
Closed

Use the codecov GH Action #83958

brettcannon opened this issue Feb 27, 2020 · 4 comments
Labels
tests Tests in the Lib/test dir

Comments

@brettcannon
Copy link
Member

BPO 39777
Nosy @brettcannon, @zooba, @ammaraskar

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2020-02-27.21:09:04.987>
labels = []
title = 'Use the codecov GH Action'
updated_at = <Date 2020-02-27.21:26:43.895>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2020-02-27.21:26:43.895>
actor = 'ammar2'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = []
creation = <Date 2020-02-27.21:09:04.987>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 39777
keywords = []
message_count = 3.0
messages = ['362839', '362843', '362845']
nosy_count = 3.0
nosy_names = ['brett.cannon', 'steve.dower', 'ammar2']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue39777'
versions = []

@brettcannon
Copy link
Member Author

Codecov provides a GH Action for uploading coverage reports which we might as well use instead of their bash uploader: https://github.com/marketplace/actions/codecov.

@ammaraskar
Copy link
Member

This has the disadvantage that it won't work for PRs because Github doesn't make secrets like ${{ secrets.CODECOV_TOKEN }} available in PRs.

See: codecov/codecov-action#29

@ammaraskar
Copy link
Member

On a second look, we currently do this anyway:

run: |
source ./.venv/bin/activate
bash <(curl -s https://codecov.io/bash)
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

and don't run coverage for PRs so it shouldn't matter.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
@iritkatriel iritkatriel added the tests Tests in the Lib/test dir label Nov 27, 2023
@hugovk
Copy link
Member

hugovk commented Feb 24, 2024

No longer relevant, we removed coverage from the CI in #25679.

@hugovk hugovk closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

No branches or pull requests

4 participants