Skip to content

Missing frame block push in compiler_async_comprehension_generator() #87661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomkpz mannequin opened this issue Mar 15, 2021 · 2 comments
Closed

Missing frame block push in compiler_async_comprehension_generator() #87661

tomkpz mannequin opened this issue Mar 15, 2021 · 2 comments
Labels
3.10 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@tomkpz
Copy link
Mannequin

tomkpz mannequin commented Mar 15, 2021

BPO 43495
Nosy @markshannon, @tomKPZ
PRs
  • bpo-43495 : Push missing frame block in compile.c #24865
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2021-03-15.00:32:22.505>
    labels = ['interpreter-core', '3.10']
    title = 'Missing frame block push in compiler_async_comprehension_generator()'
    updated_at = <Date 2021-04-07.14:44:00.034>
    user = 'https://github.com/tomkpz'

    bugs.python.org fields:

    activity = <Date 2021-04-07.14:44:00.034>
    actor = 'Mark.Shannon'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Interpreter Core']
    creation = <Date 2021-03-15.00:32:22.505>
    creator = 'tomkpz'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 43495
    keywords = ['patch']
    message_count = 2.0
    messages = ['388696', '390437']
    nosy_count = 3.0
    nosy_names = ['Mark.Shannon', 'python-dev', 'tomkpz']
    pr_nums = ['24865']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue43495'
    versions = ['Python 3.10']

    @tomkpz
    Copy link
    Mannequin Author

    tomkpz mannequin commented Mar 15, 2021

    The runtime pushes a frame block in SETUP_FINALLY, so the compiler needs to account for that, otherwise the runtime block stack may overflow.

    @tomkpz tomkpz mannequin added 3.10 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Mar 15, 2021
    @markshannon
    Copy link
    Member

    New changeset 7a7ba3d by tomKPZ in branch 'master':
    bpo-43495 : Push missing frame block in compile.c (GH-24865)
    7a7ba3d

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.10 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants