Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does ccbench still require 2.6 compatibility? #89801

Closed
smontanaro opened this issue Oct 28, 2021 · 6 comments
Closed

Does ccbench still require 2.6 compatibility? #89801

smontanaro opened this issue Oct 28, 2021 · 6 comments
Labels
3.11 only security fixes tests Tests in the Lib/test dir

Comments

@smontanaro
Copy link
Contributor

BPO 45638
Nosy @smontanaro, @terryjreedy, @ambv

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2021-10-28.00:05:44.903>
labels = ['3.11']
title = 'Does ccbench still require 2.6 compatibility?'
updated_at = <Date 2021-11-02.16:06:26.097>
user = 'https://github.com/smontanaro'

bugs.python.org fields:

activity = <Date 2021-11-02.16:06:26.097>
actor = 'terry.reedy'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = []
creation = <Date 2021-10-28.00:05:44.903>
creator = 'skip.montanaro'
dependencies = []
files = []
hgrepos = []
issue_num = 45638
keywords = []
message_count = 4.0
messages = ['405141', '405485', '405508', '405515']
nosy_count = 3.0
nosy_names = ['skip.montanaro', 'terry.reedy', 'lukasz.langa']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue45638'
versions = ['Python 3.11']

@smontanaro
Copy link
Contributor Author

At the top of Tools/ccbench/ccbench.py is this comment dating from 2010 (probably in the initial version):

# This file should be kept compatible with both Python 2.6 and Python >= 3.0.

Is there still a need for 2.6 compatibility in what is essentially a test script? There are probably only a few changes necessary to remove 2.x compatibility, but it seems odd to retain them when even the Python library documentation no longer has versionchanged/versionadded directives referencing Python 2.x.

@smontanaro smontanaro added 3.11 only security fixes labels Oct 28, 2021
@terryjreedy
Copy link
Member

Lukasz, is 'delete it' the no-brainer it seems to be?

@smontanaro
Copy link
Contributor Author

CCbench was mentioned recently in the discussion about Sam Gross's nogil branch:

https://mail.python.org/archives/list/python-dev@python.org/message/WRT7F2RHHCQ3N2TYEDC6JSIJ4T2ZM6F7/

I'm not convinced that deleting it is a no-brainer. Maybe if it landed somewhere generally useful (pyperformance?).

@terryjreedy
Copy link
Member

By 'it' I meant the comment and 2.6 compatibility you asked about.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
@iritkatriel iritkatriel added the tests Tests in the Lib/test dir label Nov 27, 2023
@StanFromIreland
Copy link
Contributor

ccbench was removed in #101853

@picnixz
Copy link
Member

picnixz commented Mar 3, 2025

Closing since this 2.6 is EOL and ccbench was removed. Thanks for digging up old issues that can be closed!

@picnixz picnixz closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2025
@picnixz picnixz closed this as completed Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.11 only security fixes tests Tests in the Lib/test dir
Projects
None yet
Development

No branches or pull requests

5 participants