Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_asyncio failures in the "Ubuntu with SSL" tests #97894

Closed
ezio-melotti opened this issue Oct 5, 2022 · 2 comments · Fixed by #97896
Closed

test_asyncio failures in the "Ubuntu with SSL" tests #97894

ezio-melotti opened this issue Oct 5, 2022 · 2 comments · Fixed by #97896
Labels
topic-asyncio type-bug An unexpected behavior, bug, or error

Comments

@ezio-melotti
Copy link
Member

ezio-melotti commented Oct 5, 2022

1 test failed:
    test_asyncio
0:01:38 load avg: 0.80
0:01:38 load avg: 0.80 Re-running failed tests in verbose mode
0:01:38 load avg: 0.80 Re-running test_asyncio in verbose mode (matching: test_eof_feed_when_closing_writer, test_wait_closed_on_close)
Warning -- Unraisable exception
Exception ignored in: <coroutine object StreamTests2.test_eof_feed_when_closing_writer at 0x7fcf806a1cd0>
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/warnings.py", line 537, in _warn_unawaited_coroutine
    warn(msg, category=RuntimeWarning, stacklevel=2, source=coro)
RuntimeWarning: coroutine 'StreamTests2.test_eof_feed_when_closing_writer' was never awaited
test_eof_feed_when_closing_writer (test.test_asyncio.test_streams.StreamTests2.test_eof_feed_when_closing_writer) ... ERROR
Warning -- Unraisable exception
Exception ignored in: <coroutine object StreamTests2.test_wait_closed_on_close at 0x7fcf806ced50>
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/warnings.py", line 537, in _warn_unawaited_coroutine
    warn(msg, category=RuntimeWarning, stacklevel=2, source=coro)
RuntimeWarning: coroutine 'StreamTests2.test_wait_closed_on_close' was never awaited
test_wait_closed_on_close (test.test_asyncio.test_streams.StreamTests2.test_wait_closed_on_close) ... ERROR

======================================================================
ERROR: test_eof_feed_when_closing_writer (test.test_asyncio.test_streams.StreamTests2.test_eof_feed_when_closing_writer)
----------------------------------------------------------------------
DeprecationWarning: It is deprecated to return a value!=None from a test case (<bound method StreamTests2.test_eof_feed_when_closing_writer of <test.test_asyncio.test_streams.StreamTests2 testMethod=test_eof_feed_when_closing_writer>>)

======================================================================
ERROR: test_wait_closed_on_close (test.test_asyncio.test_streams.StreamTests2.test_wait_closed_on_close)
----------------------------------------------------------------------
DeprecationWarning: It is deprecated to return a value!=None from a test case (<bound method StreamTests2.test_wait_closed_on_close of <test.test_asyncio.test_streams.StreamTests2 testMethod=test_wait_closed_on_close>>)

----------------------------------------------------------------------
Ran 2 tests in 0.031s

FAILED (errors=2)

This broke after this PR was merged:

(It was reported in the comments, but I'm creating this issue for visibility, since after noticing the failure in an unrelated PR I looked at the open issues and couldn't find anything.)

(cc @kumaraditya303 @gvanrossum @arhadthedev)

@ezio-melotti ezio-melotti added type-bug An unexpected behavior, bug, or error topic-asyncio labels Oct 5, 2022
@gvanrossum
Copy link
Member

I was going to wait until tomorrow morning to revert this, to give the author some more time to fix it. But if it’s problem go Shetland revert it.

@arhadthedev
Copy link
Member

The issue is fixed in gh-97896, both basic and buildbot tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-asyncio type-bug An unexpected behavior, bug, or error
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants