Skip to content

Tests for happy eyeballs + working around bug in wait_for #98388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
twisteroidambassador opened this issue Oct 18, 2022 · 0 comments
Open

Tests for happy eyeballs + working around bug in wait_for #98388

twisteroidambassador opened this issue Oct 18, 2022 · 0 comments
Labels
topic-asyncio type-bug An unexpected behavior, bug, or error

Comments

@twisteroidambassador
Copy link
Contributor

twisteroidambassador commented Oct 18, 2022 •
edited by arhadthedev
Loading

Bug report

The happy eyeballs implementation in asyncio is potentially affected by #86296 , i.e. where asyncio.wait_for may swallow cancellation.

I have added some tests for this particular problem, and some more tests for other aspects of happy eyeballs, because I didn't write any when first contributing the implementation. My bad.

The current PR only contains the tests. I'll do the actual fix later.

Linked PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-asyncio type-bug An unexpected behavior, bug, or error
Projects
asyncio
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gvanrossum @twisteroidambassador