Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35967 resolve platform.processor late #12239

Merged
merged 18 commits into from
Apr 16, 2020
Merged

bpo-35967 resolve platform.processor late #12239

merged 18 commits into from
Apr 16, 2020

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Mar 8, 2019 •
edited by bedevere-bot
Loading

@jaraco
Copy link
Member Author

jaraco commented Apr 14, 2019

I see the appveyor tests failed, but I'm going to assume that's a spurious failure, since it doesn't happen on the Azure pipelines and doesn't seem to be relevant to the test_platform tests.

@csabella csabella requested a review from malemburg June 1, 2019 15:15
@gpshead
Copy link
Member

gpshead commented Sep 12, 2019 •
edited
Loading

reopening to retrigger CI. (we removed appveyor recently)

@gpshead gpshead closed this Sep 12, 2019
@gpshead gpshead reopened this Sep 12, 2019
@jaraco
Copy link
Member Author

jaraco commented Oct 27, 2019

In the aforementioned issue, Marc agreed this approach is suitable as long as it has tests, which it does. Is anything more needed?

@jaraco jaraco added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 16, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @jaraco for commit f0daf49 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 16, 2020
@jaraco
Remove use of contextlib.suppress (it would fail with NameError if it…
d57e3ab 
… had any effect). Rely on _unknown_as_blank to replace unknown with blank.
@jaraco jaraco removed the request for review from malemburg April 16, 2020 00:39
@jaraco jaraco added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 16, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @jaraco for commit d57e3ab 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 16, 2020
@jaraco
Copy link
Member Author

jaraco commented Apr 16, 2020

Failed checks look unrelated.

@jaraco jaraco closed this Apr 16, 2020
@jaraco jaraco reopened this Apr 16, 2020
@jaraco jaraco merged commit 518835f into python:master Apr 16, 2020
@jaraco jaraco deleted the feature/35967-platform-processor-resolved-late branch April 16, 2020 12:28
@tucked tucked mentioned this pull request May 8, 2020
Closed
@methane methane mentioned this pull request Aug 5, 2021
Merged
@takluyver takluyver mentioned this pull request Sep 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaraco @gpshead @bedevere-bot @the-knights-who-say-ni