gh-126548: Add a thread-unsafety warning for importlib.reload()#136704
Merged
ZeroIntensity merged 1 commit intopython:mainfrom Jul 16, 2025
Merged
gh-126548: Add a thread-unsafety warning for importlib.reload()#136704ZeroIntensity merged 1 commit intopython:mainfrom
importlib.reload()#136704ZeroIntensity merged 1 commit intopython:mainfrom
Conversation
johnslavik
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
ZeroIntensity
added
needs backport to 3.13
ZeroIntensity
approved these changes
Jul 16, 2025
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
LGTM. The bot seems to be acting up.
johnslavik
force-pushed
the
document-reload-is-thread-unsafe
branch
from
2d580d3 to
9ab8ae3
Compare
|
Thanks @bswck for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 16, 2025
…)` (pythonGH-136704) (cherry picked from commit 69d8fe5) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 16, 2025
…)` (pythonGH-136704) (cherry picked from commit 69d8fe5) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
|
GH-136723 is a backport of this pull request to the 3.14 branch. |
|
GH-136724 is a backport of this pull request to the 3.13 branch. |
ZeroIntensity
pushed a commit
that referenced
this pull request
Jul 16, 2025
ZeroIntensity
pushed a commit
that referenced
this pull request
Jul 16, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…reload()` (pythonGH-136704) (pythonGH-136723) pythongh-126548: Add a thread-unsafety warning for `importlib.reload()` (pythonGH-136704) (cherry picked from commit 69d8fe5) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Llet me know if some rewording is needed :)
importlib.reloadis not thread-safe #126548📚 Documentation preview 📚: https://cpython-previews--136704.org.readthedocs.build/