Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wait for unrequired status checks. #130

Closed
Mariatta opened this issue Aug 5, 2018 · 4 comments
Closed

Don't wait for unrequired status checks. #130

Mariatta opened this issue Aug 5, 2018 · 4 comments

Comments

@Mariatta
Copy link
Member

Mariatta commented Aug 5, 2018

In backport PRs, if all the required status checks have completed, then go ahead and merge the PR.
Don't need to wait for the unrequired status checks.

@Mariatta
Copy link
Member Author

Mariatta commented Aug 5, 2018

GitMate.io thinks possibly related issues are python/core-workflow#72 (Add a status check for reverted commits), python/core-workflow#76 (Turn off code coverage status checks), python/core-workflow#19 (Don't wait for allowed_failures on travis builds?), #109 ("Backport status check is done, and it's a success white_check_mark ." hiccup), and python/core-workflow#269 (Improve guidance to core devs on checking CLA status).

@Mariatta
Copy link
Member Author

Mariatta commented Aug 5, 2018

Required status checks for a branch can be looked up via: https://developer.github.com/v3/repos/branches/#get-required-status-checks-of-protected-branch

@Mariatta
Copy link
Member Author

The actual API we want to use is: https://developer.github.com/v3/repos/branches/#list-required-status-checks-contexts-of-protected-branch

But this is currently blocked because miss-islington doesn't have the right permission to access that API endpoint.

@arhadthedev
Copy link
Member

No longer relevant after python/core-workflow#498.

@arhadthedev arhadthedev closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants