Update existing tests to pass

Author: msullivan

test-data/unit/check-functions.test

@@ -1397,8 +1397,8 @@ if g(C()):
 f = [] # E: Need type annotation for 'f'
 if object():
     def f(): pass # E: Incompatible redefinition
-f()
-f(1)
+f()  # E: "List[Any]" not callable
+f(1)  # E: "List[Any]" not callable
 [builtins fixtures/list.pyi]
 
 [case testDefineConditionallyAsImportedAndDecorated]

test-data/unit/check-inference.test

@@ -1291,15 +1291,15 @@ a = []  # E: Need type annotation for 'a'
 [case testInferListInitializedToEmptyAndReadBeforeAppend]
 a = []  # E: Need type annotation for 'a'
 if a: pass
-a.xyz
+a.xyz  # E: "List[Any]" has no attribute "xyz"
 a.append('')
 [builtins fixtures/list.pyi]
 [out]
 
 [case testInferListInitializedToEmptyAndIncompleteTypeInAppend]
 a = [] # E: Need type annotation for 'a'
 a.append([])
-a()
+a()  # E: "List[Any]" not callable
 [builtins fixtures/list.pyi]
 [out]
 
@@ -1335,7 +1335,7 @@ a.append(1)
 def f() -> None:
     a = []  # E: Need type annotation for 'a'
     if a: pass
-    a.xyz
+    a.xyz  # E: "List[Any]" has no attribute "xyz"
     a.append('')
 [builtins fixtures/list.pyi]
 [out]
@@ -1392,8 +1392,9 @@ class A:
         self.x = [] # E: Need type annotation for 'x'
 
 class B(A):
+    # TODO?: This error is kind of a false positive, unfortunately
     @property
-    def x(self) -> List[int]:
+    def x(self) -> List[int]:  # E: Signature of "x" incompatible with supertype "A"
         return [123]
 [builtins fixtures/list.pyi]
 [out]
@@ -1435,8 +1436,8 @@ a() # E: "Dict[str, int]" not callable
 
 [case testInferDictInitializedToEmptyUsingUpdateError]
 a = {}  # E: Need type annotation for 'a'
-a.update([1, 2])
-a()
+a.update([1, 2])  # E: Argument 1 to "update" of "dict" has incompatible type "List[int]"; expected "Mapping[Any, Any]"
+a()  # E: "Dict[Any, Any]" not callable
 [builtins fixtures/dict.pyi]
 [out]
 
@@ -2157,8 +2158,8 @@ class A:
     def f(self) -> None:
         self.x[0] = ''
 
-reveal_type(A().x)  # E: Revealed type is 'Any'
-reveal_type(A.x)  # E: Revealed type is 'Any'
+reveal_type(A().x)  # E: Revealed type is 'builtins.dict[Any, Any]'
+reveal_type(A.x)  # E: Revealed type is 'builtins.dict[Any, Any]'
 [builtins fixtures/dict.pyi]
 
 [case testLocalPartialTypesWithGlobalInitializedToEmptyList]
@@ -2179,9 +2180,9 @@ a = [] # E: Need type annotation for 'a'
 
 def f() -> None:
     a.append(1)
-    reveal_type(a)  # E: Revealed type is 'Any'
+    reveal_type(a)  # E: Revealed type is 'builtins.list[Any]'
 
-reveal_type(a) # E: Revealed type is 'Any'
+reveal_type(a) # E: Revealed type is 'builtins.list[Any]'
 [builtins fixtures/list.pyi]
 
 [case testLocalPartialTypesWithGlobalInitializedToEmptyList3]
@@ -2191,7 +2192,7 @@ a = [] # E: Need type annotation for 'a'
 def f():
     a.append(1)
 
-reveal_type(a) # E: Revealed type is 'Any'
+reveal_type(a) # E: Revealed type is 'builtins.list[Any]'
 [builtins fixtures/list.pyi]
 
 [case testLocalPartialTypesWithGlobalInitializedToEmptyDict]
@@ -2212,9 +2213,9 @@ a = {} # E: Need type annotation for 'a'
 
 def f() -> None:
     a[0] = ''
-    reveal_type(a)  # E: Revealed type is 'Any'
+    reveal_type(a)  # E: Revealed type is 'builtins.dict[Any, Any]'
 
-reveal_type(a) # E: Revealed type is 'Any'
+reveal_type(a) # E: Revealed type is 'builtins.dict[Any, Any]'
 [builtins fixtures/dict.pyi]
 
 [case testLocalPartialTypesWithGlobalInitializedToEmptyDict3]
@@ -2224,7 +2225,7 @@ a = {} # E: Need type annotation for 'a'
 def f():
     a[0] = ''
 
-reveal_type(a) # E: Revealed type is 'Any'
+reveal_type(a) # E: Revealed type is 'builtins.dict[Any, Any]'
 [builtins fixtures/dict.pyi]
 
 [case testLocalPartialTypesWithNestedFunction]