Skip to content

Optional strict checking of isinstance checks #4332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JukkaL opened this issue Dec 6, 2017 · 2 comments
Closed

Optional strict checking of isinstance checks #4332

JukkaL opened this issue Dec 6, 2017 · 2 comments

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Dec 6, 2017

The current semantics of isinstance checks make some assumptions about inheritance, such as there being no multiple inheritance from certain classes. This is probably reasonable as a default, since it makes easier to annotate legacy codebases. However, we could provide an option to have safer and stricter checking of isinstance checks. The exact behavior of this mode is still not quite clear.

See discussion in #3605 for further context.

@ilevkivskyi
Copy link
Member

Just for the reference here is the previous proposal #3603 (comment)

@msullivan
Copy link
Collaborator

I don't think this meets the bar of adding a new flag and we're moving towards more intersection stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants