Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.5.1? #7420

Closed
msullivan opened this issue Aug 29, 2019 · 5 comments
Closed

Drop support for Python 3.5.1? #7420

msullivan opened this issue Aug 29, 2019 · 5 comments

Comments

@msullivan
Copy link
Collaborator

Dropping support for 3.5.1 would save us some occasional hassle:

  • Its typing module has bugs that we have to work around
  • And typing is missing a bunch of stuff that we have to get from typing_extensions instead. (Dropping 3.5.1 support will save me from having to send a PR to pyflakes to have it understand typing_extensions.overload as a synonym for typing.overload).

We already don't support 3.5.0 so there is no new burden of explaining the lack of support for 3.5 early point releases.

mypyc only supported 3.5.2 before the merge into mypy, and fixing it was annoying if not actually hard.

There's a bunch of discussion at python-trio/trio#880

Thoughts?

@ilevkivskyi
Copy link
Member

Personally, I would love to drop 3.5.1. I thought however we still need it somewhere internally, but if it is not the case anymore, I am all in favour.

@Michael0x2a
Copy link
Collaborator

I think the last time we brought this up internally, the blocker was that 3.5.1 was apparently the default Python 3 on Ubuntu 16.04.

Though FWIW, I'm also favor in dropping support. The people who need to support Python 3.5.1 are also the ones who probably care about legacy support + supporting things like Python 2.7. And in that case, they're probably already used to running mypy using an entirely separate Python. So probably dropping support for Python 3.5.1 wouldn't be too huge a burden? Maybe this is too optimistic, not sure.

(Actually, we could take this line of reasoning one step further and also maybe justify dropping support for Python 3.5 entirely? But this is probably too aggressive, realistically speaking.)

@emmatyping
Copy link
Collaborator

I personally would be really happy to see this change. I don't think Ubuntu 16.04 should hold us back. If people really want to use a new mypy release on a 3 year old OS, I think asking them to use a separate Python is acceptable, especially since it is easy to install newer Python packages on older Ubuntu https://launchpad.net/~deadsnakes/+archive/ubuntu/ppa. Also there is now a newer LTS...

@JukkaL
Copy link
Collaborator

JukkaL commented Aug 30, 2019

Looks like Ubuntu 16.04.5 has Python 3.5.2, but earlier Ubuntu 16.04 releases have 3.5.1. I wonder if we can assume that most 16.04 users have upgraded to Ubuntu 16.04.5 or later by now (it was released Aug 2018). Looking at Ubuntu's release list, it seems that older 16.04 releases are supported until 2021. If this is the case, it would be a bit odd to only support some Ubuntu 16.04 minor releases. Other than that, I don't see major reasons not to drop support for 3.5.1, but I also don't see it as urgent since the extra maintenance burden seems pretty low?

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Oct 15, 2020

We should just drop 3.5 entirely when we drop 3.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants