Fix crashes caused by typevarlikes defaults in-place modifications #20139
+123
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19185. Fixes #19186.
Replaces #19382 (not closing that yet, need to extract another part related to
applytypefrom there to another PR).When a
TypeVardefaults to anotherTypeVar, that default should already be in scope. Fortunately we already analyze them in the correct order, so the active scope has all the necessary information. This fixes the namespace drift problem because the bound typevars are already adjusted to use the correct namespace, and we do not need to touch their global definitions.I am not super happy about making TypeVarLikeScope impure here - any suggestions? Would passing
self.msgto everybind_newcall look saner?