Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should we be using dependabot in this repo? #223

Open
mdboom opened this issue Jul 7, 2022 · 2 comments
Open

How should we be using dependabot in this repo? #223

mdboom opened this issue Jul 7, 2022 · 2 comments

Comments

@mdboom
Copy link
Contributor

mdboom commented Jul 7, 2022

I noticed a few dependabot PRs in this repo, such as this one that upgrade dependencies of specific benchmarks. While in general, I think this is good practice, for a benchmark suite, I think we'd want to upgrade these dependencies as infrequently as possible to keep benchmarking results comparable with one another (and not have to always rerun baselines). Occasionally we are forced to upgrade, for example to get compatibility with a new version of CPython, but that should be deliberate.

(It's possible there is a security counterargument to be made, but I'm not a security expert and I don't know specifically whether that matters or not).

Would it make sense to update the dependabot config to only look at the top-level dependencies of pyperformance itself rather than the dependencies of specific benchmarks?

@ericsnowcurrently
Copy link
Member

for a benchmark suite, I think we'd want to upgrade these dependencies as infrequently as possible to keep benchmarking results comparable with one another

+1

It's possible there is a security counterargument to be made

I don't consider the benchmarks to be a security concern, though I haven't done a thorough analysis of all the benchmark code. IIRC, none of the benchmarks access anything other than files they already own or temporary network services they start themselves.

Would it make sense to update the dependabot config to only look at the top-level dependencies of pyperformance itself

+1

@mdboom
Copy link
Contributor Author

mdboom commented Jul 7, 2022

It looks like this may not be easily possible: dependabot/dependabot-core#4364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants