Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-263: Run Python 3.12 task as the experimental task #274

Merged
merged 15 commits into from
Apr 19, 2023
Merged

gh-263: Run Python 3.12 task as the experimental task #274

merged 15 commits into from
Apr 19, 2023

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Apr 19, 2023 •
edited
Loading

@corona10 corona10 changed the title gh-263: Run Python 3.12 task as the experimental task [WIP] gh-263: Run Python 3.12 task as the experimental task Apr 19, 2023
@corona10 corona10 force-pushed the optional_312 branch 2 times, most recently from e23b679 to edfc331 Compare April 19, 2023 08:21
@corona10 corona10 marked this pull request as ready for review April 19, 2023 10:39
@corona10 corona10 changed the title [WIP] gh-263: Run Python 3.12 task as the experimental task gh-263: Run Python 3.12 task as the experimental task Apr 19, 2023
@corona10 corona10 requested review from hugovk and gvanrossum April 19, 2023 10:40
@corona10 corona10 mentioned this pull request Apr 19, 2023
Closed
hugovk
hugovk approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little nits but looks good :)

Note for others, looks like we need to merge this first for it to pass:
#263 (comment)

corona10 and others added 3 commits April 19, 2023 21:34
@corona10 @hugovk
Update .github/workflows/main.yml
49a6ff8 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@corona10 @hugovk
Update .github/workflows/main.yml
065be27 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@corona10 @hugovk
Update .github/workflows/main.yml
4e7712c 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@corona10 corona10 merged commit fe07325 into python:main Apr 19, 2023
@hugovk hugovk mentioned this pull request Apr 20, 2023
Closed
@hugovk hugovk mentioned this pull request Apr 20, 2023
Closed
This was referenced Oct 19, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corona10 @hugovk