You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
since the difference is in quote, I don't see a clean way to reconcile the commands by, for example, storing the command in a variable.
We require additional tools to be installed that are not in our dev requirements (wget on mac, unzip on ubuntu, wsl on Windows)
We could speed up the runs by using UV as we could assume deps in requirements-tests.txt have been installed (if we even decide to still create a different venv, rather than consolidating mypy-protobuf versions)
Our existing tooling could do some basic checks on the scripts.
I am opening this issue to share my intention, but I doubt there'd be much opposition ^^" If anyone would like to take this, let me know, otherwise I'll probably do it sometimes within the next week.
The text was updated successfully, but these errors were encountered:
I've hinted at it previously, I am now officially suggesting we rewrite the shell scripts found in
scripts
in Python instead.sed --in-place
argument #12330requirements-tests.txt
have been installed (if we even decide to still create a different venv, rather than consolidating mypy-protobuf versions)I am opening this issue to share my intention, but I doubt there'd be much opposition ^^" If anyone would like to take this, let me know, otherwise I'll probably do it sometimes within the next week.
The text was updated successfully, but these errors were encountered: