Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend google.protobuf to minimally describe the runtime_version internal module #13045

Open
blast-hardcheese opened this issue Nov 19, 2024 · 1 comment

Comments

@blast-hardcheese
Copy link

I'm pursuing better type coverage for mypy-protobuf generated stubs.

runtime_version seems to have been added in protobuf v27.0, and even though it's only intended for internal use, the lack of typing is still causing red squiggles.

What options do I have for either selectively skipping typechecking for "internal" types or would it be preferable to correctly model the exposed types in that module and mirror the comments suggesting that the module isn't intended for public consumption?

Thank you in advance

@JelleZijlstra
Copy link
Member

If the types in that module are visible to user code, then we should add them to our stubs. PR welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants