Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distutils.dist.Distribution stub missing attributes #2567

Closed
erdincmutlu opened this issue Oct 28, 2018 · 3 comments
Closed

distutils.dist.Distribution stub missing attributes #2567

erdincmutlu opened this issue Oct 28, 2018 · 3 comments
Labels
stubs: incomplete Annotations or sub-modules missing from an existing package or module

Comments

@erdincmutlu
Copy link

When working on
pypa/pip#4748
for pip._internal.locations
I am getting following errors

src\pip_internal\locations.py:166: error: Revealed type is 'distutils.dist.Distribution'
src\pip_internal\locations.py:167: error: "Distribution" has no attribute "parse_config_files"
src\pip_internal\locations.py:168: error: "Distribution" has no attribute "get_command_obj"
src\pip_internal\locations.py:188: error: "Distribution" has no attribute "get_option_dict"

Please make those stubs in typeshed

@srittau srittau added size-small stubs: incomplete Annotations or sub-modules missing from an existing package or module labels Oct 28, 2018
@srittau
Copy link
Collaborator

srittau commented Oct 28, 2018

Thank you for the report. We welcome pull requests!

@PrajwalM2212
Copy link
Contributor

Is this not a size-large issue as the only stub we have right now is class Distribution: def __init__(self, attrs: Optional[Mapping[str, Any]] = ...) -> None: ... And there is a lot of work to be done https://github.com/python/cpython/blob/master/Lib/distutils/dist.py

@srittau
Copy link
Collaborator

srittau commented Oct 29, 2018

Depends on whether to add just the attributes in the bug report or all of distutils, which is considerably more work, indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stubs: incomplete Annotations or sub-modules missing from an existing package or module
Projects
None yet
Development

No branches or pull requests

3 participants