Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types-pyOpenSSL has an obsolete dependency on types-cryptography #8699

Closed
woodruffw opened this issue Sep 7, 2022 · 2 comments
Closed

types-pyOpenSSL has an obsolete dependency on types-cryptography #8699

woodruffw opened this issue Sep 7, 2022 · 2 comments

Comments

@woodruffw
Copy link

First of all, thanks for maintaining all of these type hints! They've saved me from many bugs.

I noticed that types-pyOpenSSL depends on types-cryptography, despite types-cryptography being marked as obsolete (due to the upstream repository maintaining its own type stubs).

This causes false positives when typechecking a codebase that uses both pyOpenSSL and cryptography, as checking the former pulls in types-cryptography, which then conflicts with the correct baked-in types.

I think the fix here is to just remove the types-cryptography dependency, since it should no longer be strictly necessary. If that sounds alright, I'm happy to do a quick PR to do that.

@srittau
Copy link
Collaborator

srittau commented Sep 7, 2022

Due to limitations with our build and test system, type packages can't depend on non-type packages at the moment. This is tracked in #5768 and #5618. I'm closing this as a duplicate here as we will update all dependencies when able to do so.

@srittau srittau closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2022
@woodruffw
Copy link
Author

Thanks for the explanation, and for de-duping. I'll follow those issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants