Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The __version__ attribute is not defined #50

Closed
jorgepiloto opened this issue Jan 18, 2023 · 3 comments
Closed

The __version__ attribute is not defined #50

jorgepiloto opened this issue Jan 18, 2023 · 3 comments

Comments

@jorgepiloto
Copy link

🐞 Problem
The __version__ attribute is not defined anywhere in the source code. The dynamic field is declared in the pyproject.toml but there is no version specified in the __init__.py top file.

💡 Idea
Declare this variable in the __init__.py file. Note the value of the __version__ needs to be updated every time a release is made.

@jorgepiloto
Copy link
Author

This is related with #44.

@jorgepiloto
Copy link
Author

Pinging @koubaa.

@filmor
Copy link
Member

filmor commented Jan 18, 2023

This is not related at all to #44. #44 is about the version that is reported by the framework.

As I noted https://github.com/pythonnet/pythonnet/issues/1909#issuecomment-1250091669, you can just use importlib.metadata.version to retrieve the version, I don't see any point in complicating the build process (which your PR doesn't even touch).

@filmor filmor closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants