Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable float8 CI on sm89 #575

Closed
vkuzo opened this issue Jul 30, 2024 · 3 comments
Closed

enable float8 CI on sm89 #575

vkuzo opened this issue Jul 30, 2024 · 3 comments
Assignees
Labels

Comments

@vkuzo
Copy link
Contributor

vkuzo commented Jul 30, 2024

Float8 was moved to torchao in #551, and currently the CI that we have for float8 is running on:
a. CPU nightly (skips all cuda related tests)
b. CUDA nightly (skips all cuda related tests which require torch._scaled_mm, because the default machines used for this do not have a high enough CUDA capability version.

We should enable float8 CI on sm89 machines, which have cuda capability 8.9. The performance will not be representative, but we can at least test correctness.

Pointers:

# old
is_H100 = torch.cuda.is_available() and torch.cuda.get_device_capability() >= (9, 0)

# new
is_cuda_8_9 = torch.cuda.is_available() and torch.cuda.get_device_capability() >= (8, 9)
@vkuzo vkuzo added the float8 label Jul 30, 2024
@vkuzo
Copy link
Contributor Author

vkuzo commented Jul 30, 2024

cc @drisspg @msaroufim , @jainapurva

@msaroufim
Copy link
Member

@seemethere we could also alternatively move our CI jobs to use L4 instances which are cheaper than A10G and also support fp8. Last I tried to move our CI to use L4 i got timeouts while looking for runners so I suspect the L4 pool isn't big enough but this feels like a free efficiency win. wdyt?

@drisspg
Copy link
Contributor

drisspg commented Jul 30, 2024

One small note is that we will still need the skips on any rowwise tests since they currently require 9.0 +

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants