Minor comments on ABI stability (#4148)

NicolasHug · web-flow · commit c2c0b23ae209 · 2025-12-09T20:56:07.000+02:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -152,7 +152,7 @@ else()
 endif()
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${warning_flags} ${TORCH_CXX_FLAGS}")
 
-# Ensure that torchaudio is torch ABI stable.
+# Ensure that torchaudio is torch ABI stable with torch 2.10 onwards
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DTORCH_TARGET_VERSION=0x020a000000000000")
 
 find_program(CCACHE_PROGRAM ccache)
diff --git a/src/libtorchaudio/cuctc/src/python_binding.cpp b/src/libtorchaudio/cuctc/src/python_binding.cpp
@@ -24,7 +24,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// It is safe to temporarily disable TORCH_TARGET_VERSION for pybind11
+// Stuff in third_party/ is considered non-ABI-stable
+// (https://github.com/pytorch/pytorch/issues/169893), but
+// it is safe to temporarily disable TORCH_TARGET_VERSION for pybind11
 // as it is a header-only library.
 #ifdef TORCH_TARGET_VERSION
 #define SAVE_TORCH_TARGET_VERSION TORCH_TARGET_VERSION
diff --git a/src/libtorchaudio/pybind/pybind.cpp b/src/libtorchaudio/pybind/pybind.cpp
@@ -1,6 +1,8 @@
 #include <libtorchaudio/utils.h>
 
-// It is safe to temporarily disable TORCH_TARGET_VERSION for pybind11
+// Stuff in third_party/ is considered non-ABI-stable
+// (https://github.com/pytorch/pytorch/issues/169893), but
+// it is safe to temporarily disable TORCH_TARGET_VERSION for pybind11
 // as it is a header-only library.
 #ifdef TORCH_TARGET_VERSION
 #define SAVE_TORCH_TARGET_VERSION TORCH_TARGET_VERSION
