Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance should be named compatibility (or similar) #281

Open
jeffreyksmithjr opened this issue Sep 16, 2019 · 1 comment
Open

Compliance should be named compatibility (or similar) #281

jeffreyksmithjr opened this issue Sep 16, 2019 · 1 comment

Comments

@jeffreyksmithjr
Copy link

This bug is purely about naming. Currently, there is a layer with features equivalent to Kaldi implementations named compliance. I would argue that this is an error in diction. The definition of the word compliance I looked up is, "the state or fact of according with or meeting rules or standards." Kaldi is not a rule or standard; it's a specific technology. I believe the more accepted diction would likely be compatibility. The word compatibility has the definition, "the ability of one computer, piece of software, etc. to work with another." This is also the term that was used in the numpy compatibility project that @umanwizard and @gchanan ran.

Whether we address this issue in torchaudio specifically, I think we are likely to continue to define future compatibility layer-type features, and we should attempt to use consistent language for such features, to help users understood what is the contract of any such component.

Cc @vincentqb @cpuhrsch for discussion

@gchanan
Copy link

gchanan commented Sep 16, 2019

I believe this is a known issue, although I don't think it's been documented externally before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants