Sampling from the joint when computing qNoisyExpectedHypervolumeImprovement #2056
exs-hkenlay
started this conversation in
General
Replies: 1 comment 5 replies
-
@sdaulton Can you take a look at this? |
Beta Was this translation helpful? Give feedback.
5 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
In the forward of qNoisyExpectedHypervolumeImprovement, the input
X
of shapenum_samples, q, d
is concatenated toX_baseline
of shapenum_baseline_points, d
to giveX_full
of shapenum_samples, q + num_baseline_points, d
. The docstring has the following:I'm not sure I fully understand the last bit of the note (
given that we can already fixed the sampled function values for f(X_baseline)
), wouldn't this justify not recomputingf(X_baseline)
?For inductive methods such a BNNs the concatenation step seems unnecessary and computationally expensive if for example
X_baseline
is the training set (particularly whensequential=True
). Would it be possible/sensible to add acompute_joint = True
parameter to the__init__
so this concatenation can be turned off? I'd be happy to make an Issue and PR. Or perhaps this should be handled inside theModel
class?Beta Was this translation helpful? Give feedback.
All reactions